Skip to content

CPP: Add the Semmle security tests.#552

Merged
jbj merged 1 commit into
github:masterfrom
geoffw0:move-security-tests-add
Nov 29, 2018
Merged

CPP: Add the Semmle security tests.#552
jbj merged 1 commit into
github:masterfrom
geoffw0:move-security-tests-add

Conversation

@geoffw0

@geoffw0 geoffw0 commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

Move the Semmle security tests to public github. With only one or two exceptions, this should give test coverage for all queries in ql\cpp\ql\src\Security.

@geoffw0 geoffw0 added the C++ label Nov 27, 2018
@geoffw0 geoffw0 requested a review from a team as a code owner November 27, 2018 15:56

@jbj jbj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to add what we want. I note that the tests are passing and that all added files start with cpp/ql/test/query-tests/Security/CWE/CWE-???/semmle/, which as I understand it is the prefix you've used for tests that can be made public. Is there any reason to keep a semmle subdir under all the CWE-??? dirs?

@geoffw0

geoffw0 commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

which as I understand it is the prefix you've used for tests that can be made public

It's the prefix for tests that [we're sure] were authored by us, so we have no doubt as to our right to distribute them.

Is there any reason to keep a semmle subdir under all the CWE-??? dirs?

Yes, we still have plans to move some of the other subdirs into the public github repo (but we still have some concerns about them, and it's less urgent as they don't tend to be changed as frequently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants